[Dovecot] ManageSieve/dovecot 1.2.rc7

[Michal Hlavinka]

On Monday 29 June 2009 12:31:53 Edgar Fuß wrote:
> The ManageSieve patch for rc5 applies to rc7, but doesn't build.
>
> The problem is obvoiusly that
> dovecot-managesive/src/managesieve-login/client.c tests:
>
> #if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS >= AUTH_REQUEST_TIMEOUT*1000
> #  error client idle timeout must be smaller than authentication timeout
> #endif
>
> while dovecot/src/{pop3,imap}-login/client.c do the opposite test:
>
> #if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS < AUTH_REQUEST_TIMEOUT*1000
> #  error client idle timeout must be larger than authentication timeout
> #endif
>
> As I don't understand what this is about, I won't touch it.

this was recently changed: 
http://hg.dovecot.org/dovecot-1.2/rev/1c91fa0d804b

so I've changed it this way and it seems, it works.

-#if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS >= AUTH_REQUEST_TIMEOUT*1000
-#  error client idle timeout must be smaller than authentication timeout
+#if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS < AUTH_REQUEST_TIMEOUT*1000
+#  error client idle timeout must be larger than authentication timeout

Michal