[Dovecot] Vpopmail support broken

[Matt Brookings]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

(Re-sending this.  Didn't realize I was not replying to the list address)

On 09/22/2010 11:21 AM, Timo Sirainen wrote:
> I tried to fix 5.5 with this change:
>
> http://hg.dovecot.org/dovecot-1.2/rev/597e18c0bc7e

Vpopmail has always required vauth_open be called.  Some people have
neglected this call and so vpopmail's authentication module system was
modified to expect this.

Part of the problem with this was that vpopmail was compiled with
compiler optimizations which tended to randomize the initialization of
the variables.  Later versions of vpopmail have removed the
optimization flag.

> But I heard that it's now crashing when doing that call. (I'm not sure
> which ones of those above problems are with this change and which ones
> aren't.) And apparently that also completely broke 5.4.

It looks as if you added a call to 5.5's vauth_load_module function.
There is no problem doing this in 5.5, but 5.4 does not have this
function.  5.5 is meant to be backwards compatible with 5.4, and so,
you do not need to call this function.

> I'm not entirely sure about 5.4 problems. I think I remember someone
> saying that even when reverting the above change it didn't work.

I was able to authenticate against 5.4 cdb after removing the call to
vauth_load_module, but I have not do any long-term testing.

>> Removing the "vpopmail support broken" line from the configure script,
>> compiling and running seemed to work short-term.  I was able to
>> authenticate against the vpopmail plugin.  I tested with vpopmail
>> 5.4.32 and 5.5.0 using the cdb authentication module.

Please note that 5.5.0 is a development version, and it is the first
version in the 5.5 branch which is re-implementing a lot of old core code.

> I guess the problem is with MySQL.

Testing...
- -- 
/*
    Matt Brookings <matt at inter7.com>       GnuPG Key FAE0672C
    Software developer                     Systems technician
    Inter7 Internet Technologies, Inc.     (815)776-9465
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyaMRMACgkQIwet2/rgZyypogCaAsiYVFuyhYvazmACcH8KrLq3
lfgAn20NemKKAUhMdnHnj3PdRvvnRRfk
=VuJE
-----END PGP SIGNATURE-----