[Dovecot] Vpopmail support broken

[Matt Brookings]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/22/2010 11:48 AM, Timo Sirainen wrote:
> On Wed, 2010-09-22 at 11:38 -0500, Matt Brookings wrote:
> 
>> On 09/22/2010 11:21 AM, Timo Sirainen wrote:
>>> I tried to fix 5.5 with this change:
>>>
>>> http://hg.dovecot.org/dovecot-1.2/rev/597e18c0bc7e
>>
>> Vpopmail has always required vauth_open be called.  Some people have
>> neglected this call and so vpopmail's authentication module system was
>> modified to expect this.
> 
> Looks like I removed the above change a while after:
> http://hg.dovecot.org/dovecot-1.2/rev/7ea4e58aa356
> 
> because of: http://markmail.org/message/xvsu4z77m36suqsd
> 
> So I don't see how it could have been always required if (at least some
> versions) didn't compile with the function..

In earlier versions there were several vauth_open_* functions, each
maintained separately by each individual module that were later
condensed into vauth_open across all modules.

vpopmail's development between 5.3 and the end of 5.4 were meant to
bring everything together because parts of it didn't act like other
parts of it, etc.

5.5's goals are also quite extensive, but it will remain backwards
compatible with 5.4 calls.

> Yes, this breaks compiling with v5.4, but I remember someone saying that
> their v5.5 installation still crashes even with the vauth_load_module()
> call. (Or I think it is vauth_load_module() that crashed itself, but I
> couldn't verify by searching my old mails.)

I just completed testing of 5.4.31 MySQL and 5.5.0 MySQL.  If
vauth_open(0) is called, both versions authenticate.

Again, I need to stress that 5.5.0 is a development version.  If
something segfaults against a development version, the user should
downgrade to the stable version, but my (short-term) testing shows the
latest copy from Subversion on SourceForge authenticates.

vauth_open is the required call for all modules, across all current
versions.  I believe Dovecot is only doing read operations with
vpopmail, so it should call vauth_open(0), which establishes a
read-only connection to slave servers (if the authentication module
supports this).

Can anyone else verify this?  If it fails for you, please provide
duplication instructions, along with your configure flags for vpopmail
and its authentication module if using 5.5.

Thanks!
- -- 
/*
    Matt Brookings <matt at inter7.com>       GnuPG Key FAE0672C
    Software developer                     Systems technician
    Inter7 Internet Technologies, Inc.     (815)776-9465
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyaNr8ACgkQIwet2/rgZywcBwCgkCO+a48qpzo7xKIdZvE52tct
OxUAniafYylj8dl6uiXBnsIwBmlkCRFh
=qI5I
-----END PGP SIGNATURE-----