[Dovecot] init-script update for v2.0
Hi Timo,
please find attached a patch for the init script in the doc directory. * Added LSB-compliant info block (for insserv and friends) * Updated base_dir detection (for v2.0 config output)
Regards, Pascal
The trapper recommends today: decade.0932307@localdomain.org
Pascal Volk <user+dovecot@localhost.localdomain.org> wrote:
- Added LSB-compliant info block (for insserv and friends)
[...]
+# Required-Start: $local_fs $syslog +# Required-Stop: $local_fs $syslog +# Should-Start: $time
I think this should be $remote_fs, as according to http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generi... and http://wiki.debian.org/LSBInitScripts /usr (where dovecot probably is located) could be mounted from remote.
Also I guess $network is a good idea in Required-Start/Stop.
Bernhard
On 11/25/2009 10:17 PM Bernhard Schmidt wrote:
Pascal Volk <user+dovecot@localhost.localdomain.org> wrote:
+# Required-Start: $local_fs $syslog +# Required-Stop: $local_fs $syslog +# Should-Start: $time
I think this should be $remote_fs, as according to http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generi... and http://wiki.debian.org/LSBInitScripts /usr (where dovecot probably is located) could be mounted from remote.
Also I guess $network is a good idea in Required-Start/Stop.
My excuse: When I modified the init script, it was very urgent. ;-) Yes, mails could also be located on a $remote_fs. Many Dovecot installations uses SQL backends from the same host for passdb/userdb lookups. So I'll add postgresql and mysql. BTW: There is an interesting request for Postfix in the Debian BTS, 'Some proposal for init sequence' <http://bugs.debian.org/543472>
Regards, Pascal
The trapper recommends today: 5e1f1e55.0932918@localdomain.org
After repeated reading about {Required,Should}-{Start,Stop} I've refreshed the patch, it replaces my last patch. Sorry.
Regards, Pascal
The trapper recommends today: deadbeef.0933006@localdomain.org
On 2009-11-26 06:33:07 +0100, Pascal Volk wrote:
After repeated reading about {Required,Should}-{Start,Stop} I've refreshed the patch, it replaces my last patch. Sorry.
is /usr considered local_fs for you? i think most people install dovecot there. and atleast for my distro /usr counts under $remote_fs.
darix-- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org
On 11/26/2009 02:19 PM Marcus Rueckert wrote:
is /usr considered local_fs for you? i think most people install dovecot there. and atleast for my distro /usr counts under $remote_fs.
Assumed I've understood Required-Start and Should-Start¹, then the service, in this case Dovecot, must not start before all the services listed in Required-Start were started. If one or more of the services, which are listed in Should-Start, are available on the local system, for example postgresql, the service must not start before those services. If nothing on the local system provides postgresql, the service could start.
Please let me know if I'm still wrong.
Regards, Pascal
1 = http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generi...
The trapper recommends today: cafefeed.0933014@localdomain.org
On 2009-11-26 14:52:09 +0100, Pascal Volk wrote:
On 11/26/2009 02:19 PM Marcus Rueckert wrote:
is /usr considered local_fs for you? i think most people install dovecot there. and atleast for my distro /usr counts under $remote_fs.
Assumed I've understood Required-Start and Should-Start¹, then the service, in this case Dovecot, must not start before all the services listed in Required-Start were started. If one or more of the services, which are listed in Should-Start, are available on the local system, for example postgresql, the service must not start before those services. If nothing on the local system provides postgresql, the service could start.
Please let me know if I'm still wrong.
your patch has: # Should-Start: $remote_fs $time postgresql mysql
$time would i do as Required-Start as atleast in the past dovecot didnt handle time moving backwards.
$remote_fs is also *required* if your dovecot on /usr.
darix-- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org
On 11/26/2009 03:25 PM Marcus Rueckert wrote:
… your patch has: # Should-Start: $remote_fs $time postgresql mysql
$time would i do as Required-Start as atleast in the past dovecot didnt handle time moving backwards.
$remote_fs is also *required* if your dovecot on /usr.
Thank you for your feedback. After talking on IRC with Marco Nenciarini, about LSB comments in init scripts, this is the final version. (shameless copied from the Debian maintainers svn repository.) This patch replaces the previous one.
Regards, Pascal
The trapper recommends today: c01dcafe.0933116@localdomain.org
participants (3)
-
Bernhard Schmidt
-
Marcus Rueckert
-
Pascal Volk