[dovecot/core] 21138b: lib-test: istream-test - Don't modify existing sna...

GitHub noreply at github.com
Mon Dec 11 16:00:11 EET 2017


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 21138be4989503314641025ab07a7010a380a159
      https://github.com/dovecot/core/commit/21138be4989503314641025ab07a7010a380a159
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-test/test-istream.c

  Log Message:
  -----------
  lib-test: istream-test - Don't modify existing snapshots' memareas

At least with --enable-devel-checks this caused istream-sized unit test to
randomly panic:

Panic: file istream.c: line 279 (i_stream_read): assertion failed: (memcmp(prev_buf, prev_data + prev_skip, prev_pos - prev_skip) == 0)


  Commit: c13d3128fdf314fc8b550c9cf03fe673b33ce32f
      https://github.com/dovecot/core/commit/c13d3128fdf314fc8b550c9cf03fe673b33ce32f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Remove useless o_stream_flush() in smtp_server_connection_disconnect().

This is already performed implicitly by o_stream_uncork().
Fixes a problem found by Coverity.


  Commit: 479f238c944ecf94f05008cf14e48225743c9feb
      https://github.com/dovecot/core/commit/479f238c944ecf94f05008cf14e48225743c9feb
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-connection.c

  Log Message:
  -----------
  lib-smtp: server: Removed inappropriate NULL check in smtp_server_connection_send_replies().

Caller holds a reference, so it can never be NULL.
Found by Coverity.


  Commit: eda1c4f68f460fe9057a3a7e90249b9fa96e687e
      https://github.com/dovecot/core/commit/eda1c4f68f460fe9057a3a7e90249b9fa96e687e
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: DATA command: Fixed check for valid recipients in smtp_server_connection_data_check_state().

Can only decide whether we have valid recipients once there are no more pending RCPT commands.


  Commit: 237ff492dad72389ac4b8f5f44ec334640351b42
      https://github.com/dovecot/core/commit/237ff492dad72389ac4b8f5f44ec334640351b42
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: DATA command: Make sure there is a transaction in smtp_server_connection_data_check_state() before using it.

This fixes a potential NULL dereference.
Found by Coverity.


  Commit: e69ac57b1a97e56011e988564985728be31bfb2a
      https://github.com/dovecot/core/commit/e69ac57b1a97e56011e988564985728be31bfb2a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-command.c
    M src/lib-smtp/smtp-server.h

  Log Message:
  -----------
  lib-smtp: server: command: Added smtp_server_command_input_unlock().

Allows unlock input for a command that was earlier locked with smtp_server_command_input_lock().


  Commit: 090abb1975e23dbaebf4b07ba6003a7e54097341
      https://github.com/dovecot/core/commit/090abb1975e23dbaebf4b07ba6003a7e54097341
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: DATA command: Continue processing connection input once DATA reply is submitted.

Fixes a potential connection hang.


  Commit: 1f4f829f89c9286f52a5fac8d5f9c22f9994749a
      https://github.com/dovecot/core/commit/1f4f829f89c9286f52a5fac8d5f9c22f9994749a
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-data.c

  Log Message:
  -----------
  lib-smtp: server: DATA/BDAT command: Make sure chunk stream is dereferenced early.

The submission BURL command - which uses part of the same code - runs into trouble otherwise.
This could also be an actual istream reference leak outside BURL, but that is not confirmed.


  Commit: 6d76b99eb61df1cbe13cf76d0aac81507cbd1d21
      https://github.com/dovecot/core/commit/6d76b99eb61df1cbe13cf76d0aac81507cbd1d21
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-private.h
    M src/lib-smtp/smtp-server-transaction.c

  Log Message:
  -----------
  lib-smtp: server: transaction: Added smtp_server_transaction_rcpt_count().


  Commit: 4dd460cf19f1df3b51090427fea87e9c4b73c6d4
      https://github.com/dovecot/core/commit/4dd460cf19f1df3b51090427fea87e9c4b73c6d4
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-smtp/smtp-server-cmd-rcpt.c
    M src/lib-smtp/smtp-server-connection.c
    M src/lib-smtp/smtp-server.c
    M src/lib-smtp/smtp-server.h
    M src/lib-smtp/test-smtp-server-errors.c

  Log Message:
  -----------
  lib-smtp: server: Added max_recipients setting, which enforces a recipient limit per-transaction.


  Commit: a1852ab4cf0a942a3fcf4ca5636a7932ebcc7970
      https://github.com/dovecot/core/commit/a1852ab4cf0a942a3fcf4ca5636a7932ebcc7970
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/login-common/client-common-auth.c
    M src/login-common/client-common.c
    M src/login-common/client-common.h

  Log Message:
  -----------
  login-common: Added support for login services that handle their own input io.


  Commit: dfafc4ac89195b8cdd48afa619599d5b392ef479
      https://github.com/dovecot/core/commit/dfafc4ac89195b8cdd48afa619599d5b392ef479
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/login-common/client-common.c
    M src/login-common/client-common.h

  Log Message:
  -----------
  login-common: Added client_disconnect(), which allows explicitly disconnecting the client before it is destroyed.

This is sometimes needed to make sure the SSL layer is closed properly before destroying the underlying connection.


  Commit: f1edf7f20661ef9627acbf4054acddcba4d2eb3f
      https://github.com/dovecot/core/commit/f1edf7f20661ef9627acbf4054acddcba4d2eb3f
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/auth/mech-dovecot-token.c
    M src/imap-urlauth/imap-urlauth-client.c
    M src/imap-urlauth/imap-urlauth-client.h
    M src/imap-urlauth/imap-urlauth-login.c
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap-urlauth/imap-urlauth.c
    M src/imap/imap-client.c
    M src/lib-imap-urlauth/imap-urlauth-connection.c
    M src/lib-imap-urlauth/imap-urlauth-connection.h
    M src/lib-imap-urlauth/imap-urlauth-private.h
    M src/lib-imap-urlauth/imap-urlauth.c
    M src/lib-imap-urlauth/imap-urlauth.h

  Log Message:
  -----------
  imap-urlauth: Allow connections from services other than IMAP.

The imap-urlauth service detects the new submission service and assigns the appropriate privileges.
The dovecot-token authentication mechanism provides information on which service connected to it.


  Commit: 8c1199cac76762101a2ca3ae66443b6b0dc28683
      https://github.com/dovecot/core/commit/8c1199cac76762101a2ca3ae66443b6b0dc28683
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/imap/imap-client-hibernate.c

  Log Message:
  -----------
  imap: imap-client-hibernate: Created local variable for mail_user in imap_hibernate_write_cmd().


  Commit: 2ded32b165ce2f510f063c7da04809891c0e8cc2
      https://github.com/dovecot/core/commit/2ded32b165ce2f510f063c7da04809891c0e8cc2
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/imap/cmd-idle.c

  Log Message:
  -----------
  imap: cmd-idle: Created local variable for client in idle_add_keepalive_timeout().


  Commit: 60670187b0dd0e7f23f99a58feab11b862ad77ac
      https://github.com/dovecot/core/commit/60670187b0dd0e7f23f99a58feab11b862ad77ac
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/imap/cmd-idle.c
    M src/imap/imap-client-hibernate.c
    M src/imap/main.c
    M src/lib-storage/mail-user.c
    M src/lib-storage/mail-user.h
    M src/plugins/stats/mail-stats-connection.c
    M src/pop3/main.c

  Log Message:
  -----------
  lib-storage: Moved connection information in struct mail_user into separate struct mail_user_connection_data.


  Commit: ff4ba036fcdf28d4a1a7e3c1c6c0c71793547bd6
      https://github.com/dovecot/core/commit/ff4ba036fcdf28d4a1a7e3c1c6c0c71793547bd6
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-user.c
    M src/lib-storage/mail-user.h

  Log Message:
  -----------
  lib-storage: mail-user: Changed mail_user_set_vars() to accept struct mail_user_connection_data, rather than individual fields.


  Commit: 9666d130b63653a5a6d5d2f38ca2df72a5f3f7a7
      https://github.com/dovecot/core/commit/9666d130b63653a5a6d5d2f38ca2df72a5f3f7a7
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/login-common/client-common.c
    M src/login-common/client-common.h

  Log Message:
  -----------
  login-common: Added flag to client that indicates whether connection is secured using SSL specifically.


  Commit: e213fe0f4040bb6001e76edd51131ccf18129a3f
      https://github.com/dovecot/core/commit/e213fe0f4040bb6001e76edd51131ccf18129a3f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lib-master/master-auth.h
    M src/login-common/sasl-server.c

  Log Message:
  -----------
  lib-master: master-auth: Pass more information about the user connection to the backend in struct master_auth_request.

Adds remote and local ports and security information about the connection.
This changes the master-auth protocol incompatibly, so the major version is updated.


  Commit: 211caf3c233d562b0c8137e5eefae3cb1ef13003
      https://github.com/dovecot/core/commit/211caf3c233d562b0c8137e5eefae3cb1ef13003
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/imap/main.c
    M src/lib-storage/mail-storage-service.c
    M src/lib-storage/mail-storage-service.h
    M src/lib-storage/mail-user.h
    M src/lmtp/client.c
    M src/lmtp/lmtp-local.c
    M src/pop3/main.c

  Log Message:
  -----------
  lib-storage: mail-user: Added more information about the client connection.

Submission service will need it to pass to the backend MTA in XCLIENT and for creating the "Received:" header.


  Commit: 2cbbe9b4829adb184c83dbf780316f4144559054
      https://github.com/dovecot/core/commit/2cbbe9b4829adb184c83dbf780316f4144559054
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M .gitignore
    M TODO
    M configure.ac
    M doc/example-config/conf.d/10-director.conf
    M doc/example-config/conf.d/10-master.conf
    M doc/example-config/conf.d/10-ssl.conf
    A doc/example-config/conf.d/20-submission.conf
    M doc/example-config/dovecot.conf
    M src/Makefile.am
    A src/submission-login/Makefile.am
    A src/submission-login/client-authenticate.c
    A src/submission-login/client-authenticate.h
    A src/submission-login/client.c
    A src/submission-login/client.h
    A src/submission-login/submission-login-settings.c
    A src/submission-login/submission-login-settings.h
    A src/submission-login/submission-proxy.c
    A src/submission-login/submission-proxy.h
    A src/submission/Makefile.am
    A src/submission/cmd-data.c
    A src/submission/cmd-helo.c
    A src/submission/cmd-mail.c
    A src/submission/cmd-noop.c
    A src/submission/cmd-quit.c
    A src/submission/cmd-rcpt.c
    A src/submission/cmd-rset.c
    A src/submission/cmd-vrfy.c
    A src/submission/main.c
    A src/submission/submission-client.c
    A src/submission/submission-client.h
    A src/submission/submission-commands.c
    A src/submission/submission-commands.h
    A src/submission/submission-common.h
    A src/submission/submission-settings.c
    A src/submission/submission-settings.h

  Log Message:
  -----------
  Implemented SMTP submission proxy service.


Compare: https://github.com/dovecot/core/compare/ea4a85f5883b...2cbbe9b4829a


More information about the dovecot-cvs mailing list