[dovecot/core] 823802: lmtp: Removed useless ssl_start parameter for clie...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 823802b00ed82188e8666ad980379070e89c9009
      https://github.com/dovecot/core/commit/823802b00ed82188e8666ad980379070e89c9009
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lmtp/client.c
    M src/lmtp/client.h
    M src/lmtp/main.c

  Log Message:
  -----------
  lmtp: Removed useless ssl_start parameter for client_create().

The same information is already contained in the conn parameter.


  Commit: b1aac3a1d59d47a1fca5e4d7ac274089336f2c4f
      https://github.com/dovecot/core/commit/b1aac3a1d59d47a1fca5e4d7ac274089336f2c4f
  Author: Stephan Bosch <stephan.bosch at dovecot.fi>
  Date:   2017-12-11 (Mon, 11 Dec 2017)

  Changed paths:
    M src/lmtp/client.c

  Log Message:
  -----------
  lmtp: Fix segfault occurring in client_read_settings().

This problem is caused by recent changes.
The code attempts to access client->conn to obtain connection security info, which is not yet assigned at that point.
It is doubtful whether assigning those security flags is useful at that stage, but it now uses the ssl flag from the master_service_connection instead.


Compare: https://github.com/dovecot/core/compare/2cbbe9b4829a...b1aac3a1d59d