[dovecot/core] 04c8a9: director: Make sure user's timestamp isn't set to ...

GitHub noreply at github.com
Sat Nov 25 01:00:09 EET 2017


  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 04c8a9554e34ad1afed9291e673cd452ee93e849
      https://github.com/dovecot/core/commit/04c8a9554e34ad1afed9291e673cd452ee93e849
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-24 (Fri, 24 Nov 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Make sure user's timestamp isn't set to future

The sending director could have the system clock slightly in the future.


  Commit: 0e94f6c27bffd58953b3479415532bff2bc04732
      https://github.com/dovecot/core/commit/0e94f6c27bffd58953b3479415532bff2bc04732
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-24 (Fri, 24 Nov 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Make sure users are sorted after unfinished handshake

The users were sorted after the handshake was finished, but if the
connection was closed before that hapepned, the users were left
unsorted. This could have caused the users to not expire early
enough.


  Commit: 94fb15fffc814d7dcecabf8d90691502311d4b88
      https://github.com/dovecot/core/commit/94fb15fffc814d7dcecabf8d90691502311d4b88
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-24 (Fri, 24 Nov 2017)

  Changed paths:
    M src/director/director-connection.c
    M src/director/user-directory.c

  Log Message:
  -----------
  director: Keep users unsorted during handshake and sort them at the end

This is simpler and sometimes more efficient than the current way of
immediately inserting the users to the correct place in the linked list.
This is especially useful if handshaking is mixed with regular USER updates,
because each switch between them required walking the linked list backwards
to find the proper insert position.

It's not a big problem if the users list is temporarily unordered. It mainly
means that some of the users won't be expired as early as they should have.


Compare: https://github.com/dovecot/core/compare/c147bff81879...94fb15fffc81


More information about the dovecot-cvs mailing list