[dovecot/core] a419c0: director: Make sure user's timestamp isn't set to ...

GitHub noreply at github.com
Sun Nov 26 01:00:14 EET 2017


  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: a419c0354d0552c112fe0f5ba503853288061c91
      https://github.com/dovecot/core/commit/a419c0354d0552c112fe0f5ba503853288061c91
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-26 (Sun, 26 Nov 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Make sure user's timestamp isn't set to future

The sending director could have the system clock slightly in the future.


  Commit: 27d45a6cee1b198be054d596ecac3aa18d9570a2
      https://github.com/dovecot/core/commit/27d45a6cee1b198be054d596ecac3aa18d9570a2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-26 (Sun, 26 Nov 2017)

  Changed paths:
    M src/director/director-connection.c

  Log Message:
  -----------
  director: Make sure users are sorted after unfinished handshake

The users were sorted after the handshake was finished, but if the
connection was closed before that hapepned, the users were left
unsorted. This could have caused the users to not expire early
enough.


  Commit: 7e6f293db82647f027a5441720c5a813c1844c03
      https://github.com/dovecot/core/commit/7e6f293db82647f027a5441720c5a813c1844c03
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2017-11-26 (Sun, 26 Nov 2017)

  Changed paths:
    M src/director/director-connection.c
    M src/director/user-directory.c

  Log Message:
  -----------
  director: Keep users unsorted during handshake and sort them at the end

This is simpler and sometimes more efficient than the current way of
immediately inserting the users to the correct place in the linked list.
This is especially useful if handshaking is mixed with regular USER updates,
because each switch between them required walking the linked list backwards
to find the proper insert position.

It's not a big problem if the users list is temporarily unordered. It mainly
means that some of the users won't be expired as early as they should have.


Compare: https://github.com/dovecot/core/compare/0bd35db68be7...7e6f293db826


More information about the dovecot-cvs mailing list