[Dovecot] 1.0-test67 - Cache Bug

[Timo Sirainen]

On 8.4.2005, at 06:50, Andrew Hutchings wrote:

> Hi Timo,
> It seems in test67 if you use a {scheme}password in the database to
> override the default scheme and cache is on the following happens:
>
> 270276-Apr  8 04:43:25 svr21 dovecot: auth(default): file
> passdb-cache.c: line 30 (list_save): assertion failed: (*value == '{')

Maybe this then..:

Index: auth-request.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/auth/auth-request.c,v
retrieving revision 1.18
diff -u -r1.18 auth-request.c
--- auth-request.c      7 Apr 2005 23:42:46 -0000       1.18
+++ auth-request.c      8 Apr 2005 10:27:30 -0000
@@ -421,6 +421,7 @@
                         request->passdb_password =
                                 p_strdup(request->pool, value);
                 } else {
+                       i_assert(default_scheme != NULL);
                         request->passdb_password =
                                 p_strdup_printf(request->pool, "{%s}%s",
                                                 default_scheme, value);
Index: passdb-cache.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/auth/passdb-cache.c,v
retrieving revision 1.9
diff -u -r1.9 passdb-cache.c
--- passdb-cache.c      7 Apr 2005 23:42:46 -0000       1.9
+++ passdb-cache.c      8 Apr 2005 10:27:30 -0000
@@ -27,7 +27,6 @@
                         value++;
                 }

-               i_assert(*value == '{');
                 auth_request_set_field(request, name, value, NULL);
                 t_pop();
         }

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://dovecot.org/pipermail/dovecot/attachments/20050408/39ba6870/attachment-0001.bin>