[Dovecot] 1.0-test70

[Timo Sirainen]

On 19.5.2005, at 11:48, Jens Laas wrote:

>> - pop3 hang fix
>
> pop3 still hangs for me.

Looks like my previous "fix" didn't actually do anything. Hmm. I looked 
at it quite a long time but couldn't really think of anything.. Or 
would the patch below help? If not I'll send you a patch that adds some 
debugging lines..

diff -u -r1.48 ostream-file.c
--- src/lib/ostream-file.c      26 Apr 2005 11:08:16 -0000      1.48
+++ src/lib/ostream-file.c      23 May 2005 22:37:21 -0000
@@ -220,8 +220,10 @@

         if (fstream->corked != set && !stream->ostream.closed) {
                 if (set && fstream->io != NULL) {
-                       io_remove(fstream->io);
-                       fstream->io = NULL;
+                       if (!fstream->flush_pending) {
+                               io_remove(fstream->io);
+                               fstream->io = NULL;
+                       }
                 } else if (!set) {
                         ret = buffer_flush(fstream);
                         if (fstream->io == NULL &&

> Would it be possible to have some code that detected this condition 
> and kickstarted the output (until all the bugs are found) ?

I guess that could be done, but I'd rather spend the time finding the 
problem than writing a horrible hack :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://dovecot.org/pipermail/dovecot/attachments/20050524/c2611fe8/attachment-0001.bin>