[Dovecot] Re: Getting maildir++ quotas working

[Timo Sirainen]

On Tue, 2006-04-04 at 22:25 -0400, Bill Boebel wrote:
> --- src/plugins/imap-quota/imap-quota-plugin.c 2006-04-04
> 17:32:51.173260878 -0400
> +++ src/plugins/imap-quota/imap-quota-plugin.c.1   2006-04-04
> 17:32:42.972572807 -0400
> @@ -29,7 +29,7 @@
>     list = quota_root_get_resources(root);
>     for (i = 0; *list != NULL; list++, i++) {
>         ret = quota_get_resource(root, *list, &value, &limit);
> -       if (ret > 0) {
> +       if (ret >= 0) {
>             if (i > 0)
>                 str_append_c(str, ' ');
>             str_printfa(str, "%s %llu %llu", *list,

Oh. This is actually the wrong fix though, correct fix is to make
maildir_quota_get_resource() return 1 instead of 0.

> --- configure   2006-04-04 22:21:37.000000000 -0400
> +++ configure.1 2006-04-04 22:21:27.000000000 -0400
> @@ -31096,7 +31096,7 @@
> 
> 
> 
> -capability="IMAP4rev1 SORT THREAD=REFERENCES MULTIAPPEND UNSELECT
> LITERAL+ IDLE CHILDREN NAMESPACE LOGIN-REFERRALS"
> +capability="IMAP4rev1 SORT THREAD=REFERENCES MULTIAPPEND UNSELECT
> LITERAL+ IDLE CHILDREN NAMESPACE LOGIN-REFERRALS QUOTA"

Yea, I guess this should be made runtime configurable. Even better would
be some automation by looking at what plugins are used, but I'm not sure
how well that would work.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20060406/577e95fa/attachment-0001.pgp