[Dovecot] BUG in RC10 deliver using mbox format

[Timo Sirainen]

On Fri, 2006-10-27 at 21:34 -0500, Steven F Siirila wrote:
> After recently adding the -f parameter to the call to the deliver command
> which is called by Postfix, I found that e-mail with a null return path
> (MAIL FROM:<>) was causing Dovecot deliver to SEGFAULT.  I verified this
> by making this patch to deliver.c (notice I fixed a typo here, too):

Thanks, fixed (slightly differently).

> While this fixed my SEGFAULT, it still leaves the "From_" line with the
> default "dovecot.deliver" as the return path, something I don't want.
> It should be "MAILER-DAEMON" or some-such just like all the other LDAs
> in the case of a NULL return path.  Perhaps there needs to be a new
> parameter so one can specify what a NULL return path should be converted to
> when it is encountered...

I changed the default to MAILER-DAEMON. I don't think there needs to be
a new parameter/setting just for that.

> Also, note that the "Usage" message in deliver.c does not include the
> relatively new -f option either, so that should have been part of my
> above patch as well.

Added.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20061102/c2e8ca10/attachment.pgp