[Dovecot] Wrong UIDs returned from mailbox_transaction_commit_get_uids()

[Timo Sirainen]

On Mon, 2008-03-31 at 23:46 -0700, Ron Avriel wrote:
> Hi,
> 
> Wrong UIDs are returned from mailbox_transaction_commit_get_uids() in dovecot-1.1.rc3.

Where do you see this causing problems?

> The problem is in:
> 
> int mailbox_transaction_commit(struct mailbox_transaction_context **t)
> {
>     uint32_t tmp;
> 
>     return mailbox_transaction_commit_get_uids(t, &tmp, &tmp, &tmp);
> }
> 
> 
> It should be:
> 
> int mailbox_transaction_commit(struct mailbox_transaction_context **t)
> {
>     uint32_t tmp1, tmp2, tmp3;
> 
>     return mailbox_transaction_commit_get_uids(t, &tmp1, &tmp2, &tmp3);
> }

How/where does this help? The tmp values are ignored in any case, so I
don't think this is the right fix for it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://dovecot.org/pipermail/dovecot/attachments/20080401/37c5c2ee/attachment.bin