April 2017 - dovecot - dovecot.org

2.2 -git fails to compile as of Apr 28 2017
by Reuben Farrelly 09 May '17

09 May '17

This has been broken for the last few days: libtool: link: ( cd ".libs" && rm -f "lib10_quota_plugin.la" && ln -s "../lib10_quota_plugin.la" "lib10_quota_plugin.la" ) libtool: link: x86_64-pc-linux-gnu-gcc -std=gnu99 -O2 -pipe -march=native -mtune=native -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast -fno-builtin-strftime -Wstrict-aliasing=2 -Wl,-O1 -o .libs/quota-status quota-status.o .libs/quota.o .libs/quota-count.o .libs/quota-fs.o .libs/quota-dict.o .libs/quota-dirsize.o .libs/quota-imapc.o .libs/quota-maildir.o .libs/quota-plugin.o .libs/quota-storage.o .libs/quota-util.o .libs/rquota_xdr.o -Wl,--export-dynamic -Wl,--as-needed ../../../src/lib-storage/.libs/libdovecot-storage.so /var/tmp/portage/net-mail/dovecot-9999_p20170427/work/dovecot-9999_p20170427/src/lib-dovecot/.libs/libdovecot.so ../../../src/lib-imap-storage/.libs/libimap-storage.a ../../../src/lib-dovecot/.libs/libdovecot.so -ldl -Wl,-rpath -Wl,/usr/lib64/dovecot .libs/quota-imapc.o: In function `imapc_quota_refresh': quota-imapc.c:(.text+0x8dd): undefined reference to `imapc_storage_client_register_untagged' quota-imapc.c:(.text+0x8f7): undefined reference to `imapc_storage_client_register_untagged' quota-imapc.c:(.text+0x90a): undefined reference to `imapc_client_get_capabilities' quota-imapc.c:(.text+0x964): undefined reference to `imapc_simple_context_init' quota-imapc.c:(.text+0x975): undefined reference to `imapc_simple_callback' quota-imapc.c:(.text+0x97e): undefined reference to `imapc_client_cmd' quota-imapc.c:(.text+0x996): undefined reference to `imapc_command_sendf' quota-imapc.c:(.text+0x99e): undefined reference to `imapc_simple_run' quota-imapc.c:(.text+0xaab): undefined reference to `imapc_simple_context_init' quota-imapc.c:(.text+0xabc): undefined reference to `imapc_simple_callback' quota-imapc.c:(.text+0xac5): undefined reference to `imapc_client_cmd' quota-imapc.c:(.text+0xadd): undefined reference to `imapc_command_sendf' quota-imapc.c:(.text+0xae5): undefined reference to `imapc_simple_run' collect2: error: ld returned 1 exit status make[4]: *** [Makefile:694: quota-status] Error 1 make[4]: Leaving directory '/var/tmp/portage/net-mail/dovecot-9999_p20170427/work/dovecot-9999_p20170427/src/plugins/quota'

3 7

Sieve dict and bindir question
by Alessio Cecchi 03 May '17

03 May '17

Hi, I have setup the latest Dovecot and Sieve with dict in order to read rules from MySQL and works fine: sieve_before = dict:proxy::sieve;name=activesql;bindir=~/.sieve-bin dict { sieve = mysql:/etc/dovecot/dovecot-dict-sieve-sql.conf.ext } # cat /etc/dovecot/dovecot-dict-sieve-sql.conf.ext connect = host=10.1.1.1 dbname=dovecot user=dovecot password=Ciao map { pattern = priv/sieve/name/$script_name table = user_sieve_scripts username_field = username value_field = id fields { script_name = $script_name } } map { pattern = priv/sieve/data/$id table = user_sieve_scripts username_field = username value_field = script_data fields { id = $id } } But when I update the rules in mysql sieve continue to apply only the "old" rules stored in the binary. The only way to apply the new rules is to delete the .sieve-bin/activesql.svbin. If I remove ";bindir=~/.sieve-bin" works fine. This is a cache issue and can be fixed via setting, is an issue or is a "feature" :-) ? Thanks -- Alessio Cecchi Postmaster @ http://www.qboxmail.it https://www.linkedin.com/in/alessice

3 4

most secure password scheme
by David Mehler 30 Apr '17

30 Apr '17

Hello, I have a few questions on password schemes. Is SHA512 the most secure? Is there a difference between SHA512 and SHA512-CRYPT? What about SSHA512 and SSH512-CRYPT? Is there a problem with this sql statement: UPDATE virtual_users SET password=CONCAT(‘{SHA256-CRYPT}’, ENCRYPT (‘Password Goes Here’, CONCAT(‘$5$’, SUBSTRING(SHA(RAND()), -16)))) WHERE user=’user(a)example.xn--com-to0a; I'm getting an error 1064 at the ending email address. Thanks. Dave.

3 4

IMAP hibernate and scalability in general
by Christian Balzer 30 Apr '17

30 Apr '17

Hello, as some may remember, we're running very dense IMAP cluster here, in excess of 50k IMAP sessions per node (current record holder is 68k, design is for 200k+). The first issue we ran into was that the dovecot master process (which is single thread and thus a bottleneck) was approaching 100% CPU usage (aka using a full core) when trying to spawn off new IMAP processes. This was rectified by giving IMAP a service count of 200 to create a pool of "idling" processes eventually, reducing the strain for the master process dramatically. That of course required generous cranking up ulimits, FDs in particular. The next issues of course is (as mentioned before) the memory usage of all those IMAP processes and the fact that quite a few things outside of dovecote (ps, etc) tend to get quite sedate when dealing with tens of thousands of processes. We just started to deploy a new mailbox cluster pair with 2.2.27 and having IMAP hibernate configured. Getting this work is a PITA though with regards to ownership and access rights to the various sockets, this part could definitely do with some better (I know, difficult) defaults or at least more documentation (none besides the source and this ML). Initial results are very promising, depending on what your clients are doing (are they well behaved, are your users constantly looking at other folders, etc) the vast majority of IDLE processes will be in hibernated at any given time and thus not only using a fraction of the RAM otherwise needed but also freeing up process space. Real life example: 240 users, 86 imap processes (80% of those not IDLE) and: dovecot 119157 0.0 0.0 10452 3236 ? S Apr01 0:21 dovecot/imap-hibernate [237 connections] That's 237 hibernated connections and thus less processes than otherwise. I assume that given the silence on the ML what we are going to be the first hibernate users where the term "large scale" does apply. Despite that I have some questions, clarifications/confirmations: Our current default_client_limit is 16k, which can be seen by having 5 config processes on our 65k+ session node. ^_- This would also apply to imap-hibernate, one wonders if that's fine (config certainly has no issues) or if something smaller would be appropriate here? Since we have idling IMAP processes around most of the time, the strain of re-spawning proper processes from imap-hibernate should be just as reduced as for the dovecot master, correct? I'll keep reporting our experiences here, that is if something blows up spectacularly. ^o^ Christian -- Christian Balzer Network/Systems Engineer chibi(a)gol.com Global OnLine Japan/Rakuten Communications http://www.gol.com/

4 16

Re: Dovecot last_login plugin and Mysql
by David Mehler 29 Apr '17

29 Apr '17

Hi, Thanks for the pointing out of the oops! I missed that. Don't worry that has been changed. Any suggestions on my issue? Thanks. Dave. On 4/28/17, David Mehler <dave.mehler(a)gmail.com> wrote: > Hi, > > OOPS! I missed that one and it was big. > > Changing now. > > Thanks. > Dave. > > > On 4/28/17, Noel Butler <noel.butler(a)ausics.net> wrote: >> ummmmmm >> >> It's usually a good idea to redact user and passwords for databases, >> even if only local socket ;) >> >> I suggest you change it ASAP. >> >> On 29/04/2017 10:53, David Mehler wrote: >> >>> Hello, >>> >>> Here is the requested file: >>> >>> driver = mysql >>> connect = host=/tmp/mysql.sock dbname=mail user=mail_admin >>> password=MainBoard55 >>> >>> # Last Login >>> map { >>> pattern = shared/last-login/$user >>> table = virtual_users >>> username_field = user >>> value_field = lastlogin >>> fields { >>> user = $user >>> } >>> } >>> >>> Thanks. >>> Dave. >>> >>> On 4/28/17, Aki Tuomi <aki.tuomi(a)dovecot.fi> wrote: >>> On April 29, 2017 at 12:29 AM David Mehler <dave.mehler(a)gmail.com> >>> wrote: >>> >>> Hello, >>> >>> Trying to implement lastlogin via mysql. I'm getting an unknown column >>> username which I don't get. Here's the log: >>> >>> Apr 28 17:18:15 ohio dovecot: imap-login: Login: >>> user=<user(a)example.com>, method=PLAIN, rip=127.0.0.1, lip=127.0.0.1, >>> mpid=16257, secured, session=<KxiSnEBOwUx/AAAB> >>> >>> Apr 28 17:18:15 ohio dovecot: dict(17099): Error: sql dict: commit >>> failed: Unknown column 'username' in 'field list' >>> >>> Apr 28 17:18:15 ohio dovecot: imap(user(a)example.com): Error: >>> dict-client: server returned failure: 1493414295 (reply took 0.026 >>> secs) >>> >>> Apr 28 17:18:15 ohio dovecot: imap(user(a)example.com): Error: >>> last_login_dict: Failed to write value for user user(a)example.com >>> >>> You can configure all this in dovecot-dict-sql.conf, which you have not >>> provided. The actual column names are defined there. >>> >>> Aki >> >> -- >> Kind Regards, >> >> Noel Butler >> >> This Email, including any attachments, may contain legally privileged >> information, therefore remains confidential and subject to copyright >> protected under international law. You may not disseminate, discuss, or >> reveal, any part, to anyone, without the authors express written >> authority to do so. If you are not the intended recipient, please notify >> the sender then delete all copies of this message including attachments, >> immediately. Confidentiality, copyright, and legal privilege are not >> waived or lost by reason of the mistaken delivery of this message. Only >> PDF [1] and ODF [2] documents accepted, please do not send proprietary >> formatted documents >> >> >> >> Links: >> ------ >> [1] http://www.adobe.com/ >> [2] http://en.wikipedia.org/wiki/OpenDocument >

2 1

configuration sanity check
by David Mehler 29 Apr '17

29 Apr '17

Hello, Can I get a sanity check on this configuration? It's a database setup of Dovecot 2.2 with Postfix. I'm having issues and i'd like to know if there's anything glaringly wrong with my configuration? With the password hash situation, should I go with SHA512, SHA512-CRYPT or the SSHA512-CRYPT? Thanks. Dave. # 2.2.29.1 (e0b76e3): /usr/local/etc/dovecot/dovecot.conf # Pigeonhole version 0.4.18 (29cc74d) # OS: FreeBSD 10.3-RELEASE-p18 amd64 auth_default_realm = example.com auth_mechanisms = plain login cram-md5 auth_realms = example.com example.net dict { acl = mysql:/usr/local/etc/dovecot/dovecot-share-folder.conf lastlogin = mysql:/usr/local/etc/dovecot/dovecot-last-login.conf sqlquota = mysql:/usr/local/etc/dovecot/dovecot-used-quota.conf } disable_plaintext_auth = yes first_valid_gid = 999 first_valid_uid = 999 hostname = mail.example.com imap_client_workarounds = delay-newmail tb-extra-mailbox-sep tb-lsub-flags last_valid_gid = 999 last_valid_uid = 999 lda_mailbox_autocreate = yes lda_mailbox_autosubscribe = yes listen = 127.0.0.1 xxx.xxx.xxx.xxx mail_fsync = never mail_gid = vmail mail_home = /home/vmail/%d/%n mail_location = maildir:~/mail/:LAYOUT=fs:INDEX=~/mail/ mail_plugins = acl mail_log notify quota quota_clone trash virtual welcome zlib mail_server_admin = mailto:postmaster@example.com mail_uid = vmail mailbox_list_index = yes managesieve_notify_capability = mailto managesieve_sieve_capability = fileinto reject envelope encoded-character vacation subaddress comparator-i;ascii-numeric relational regex imap4flags copy include variables body enotify environment mailbox date index ihave duplicate mime foreverypart extracttext imapflags notify imapsieve vnd.dovecot.imapsieve namespace { hidden = no list = yes location = maildir:/home/vmail/public:LAYOUT=fs:CONTROL=~/mail/public:INDEXPVT=~/mail/public:INDEX=~/mail/public mailbox TestFolder { auto = subscribe comment = Public Folder for message sharing } prefix = public/ separator = / subscriptions = yes type = public } namespace { list = yes location = maildir:~/mail/:INDEX=~/mail/shared/%%Ld/%%Ln prefix = shared/%%u/ separator = / subscriptions = yes type = shared } namespace { location = virtual:/usr/local/etc/dovecot/virtual mailbox All { auto = subscribe comment = All my messages special_use = \All } prefix = virtual/ separator = / } namespace inbox { inbox = yes location = mailbox Archive { auto = no special_use = \Archive } mailbox Archives { auto = subscribe special_use = \Archive } mailbox "Deleted Messages" { auto = no autoexpunge = 30 days special_use = \Trash } mailbox Drafts { auto = subscribe special_use = \Drafts } mailbox Junk { auto = no autoexpunge = 30 days special_use = \Junk } mailbox "Junk E-mail" { auto = no autoexpunge = 30 days special_use = \Junk } mailbox Sent { auto = subscribe special_use = \Sent } mailbox "Sent Items" { auto = no special_use = \Sent } mailbox "Sent Messages" { auto = no special_use = \Sent } mailbox Spam { auto = subscribe autoexpunge = 30 days special_use = \Junk } mailbox Trash { auto = subscribe autoexpunge = 30 days special_use = \Trash } prefix = separator = / type = private } passdb { args = /usr/local/etc/dovecot/dovecot-sql.conf.ext driver = sql } plugin { acl = vfile:/usr/local/etc/dovecot/global-acls:cache_secs=300 acl_anyone = allow acl_shared_dict = file:/usr/local/etc/dovecot/shared-mailboxes imapsieve_mailbox1_before = file:/usr/local/lib/dovecot/sieve/report-spam.sieve imapsieve_mailbox1_causes = COPY imapsieve_mailbox1_name = Spam imapsieve_mailbox2_before = file:/usr/local/lib/dovecot/sieve/report-ham.sieve imapsieve_mailbox2_causes = COPY imapsieve_mailbox2_from = Spam imapsieve_mailbox2_name = * last_login_dict = proxy::lastlogin last_login_key = last-login/%u mail_log_events = delete undelete expunge copy mailbox_delete mailbox_rename mail_log_fields = uid box msgid size quota = count:User quota quota_clone_dict = proxy::sqlquota quota_exceeded_message = Storage quota for this account has been exceeded, please try again later. quota_grace = 10%% quota_status_nouser = DUNNO quota_status_overquota = 552 5.2.2 Mailbox is full quota_status_success = DUNNO quota_vsizes = true quota_warning = storage=100%% quota-exceeded 100 %u quota_warning2 = storage=95%% quota-warning 95 %u quota_warning3 = storage=90%% quota-warning 90 %u quota_warning4 = storage=85%% quota-warning 85 %u quota_warning5 = storage=75%% quota-warning 75 %u sieve = /home/vmail/%d/sieve/dovecot.sieve sieve_before = /home/vmail/sieve/dovecot.sieve sieve_default = /usr/local/etc/dovecot/sieve/dovecot.sieve sieve_dir = /usr/local/etc/dovecot/sieve sieve_extensions = +notify +imapflags sieve_global_dir = /home/vmail/sieve sieve_global_extensions = +vnd.dovecot.pipe +vnd.dovecot.execute sieve_max_redirects = 30 sieve_max_script_size = 1M sieve_pipe_bin_dir = /usr/local/lib/dovecot/sieve sieve_plugins = sieve_imapsieve sieve_extprograms sieve_user_log = /home/vmail/sieve/sieve_error.log trash = /usr/local/etc/dovecot/dovecot-trash.conf.ext welcome_script = welcome %u welcome_wait = yes } protocols = imap sieve sendmail_path = /usr/local/sbin/sendmail service auth { unix_listener /var/spool/postfix/private/auth { mode = 0666 } unix_listener auth-userdb { group = vmail mode = 0666 user = vmail } } service dict { unix_listener dict { mode = 0660 user = vmail } } service imap-login { inet_listener imap { port = 143 } inet_listener imaps { port = 993 ssl = yes } } service managesieve-login { inet_listener sieve { address = 127.0.0.1 port = 4190 } } service quota-status { client_limit = 1 executable = quota-status -p postfix inet_listener { address = 127.0.0.1 port = 12345 } } service quota-warning { executable = script /usr/local/etc/dovecot/quota-warning.sh unix_listener quota-warning { group = vmail mode = 0660 user = vmail } user = vmail } service welcome { executable = script /usr/local/bin/welcome.sh unix_listener welcome { user = vmail } user = vmail } ssl_cert = </usr/local/etc/letsencrypt/live/mail.example.com/fullchain.pem ssl_cipher_list = ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256@STRENGTH ssl_dh_parameters_length = 2048 ssl_key = # hidden, use -P to show it ssl_prefer_server_ciphers = yes ssl_protocols = !SSLv2 !SSLv3 !TLSv1 !TLSv1.1 userdb { driver = prefetch } userdb { args = /usr/local/etc/dovecot/dovecot-sql.conf.ext driver = sql } userdb { args = uid=vmail gid=vmail home=/home/vmail/%d/%n driver = static } protocol lda { mail_fsync = optimized mail_plugins = acl mail_log notify quota quota_clone trash virtual welcome zlib sieve } protocol imap { mail_plugins = acl mail_log notify quota quota_clone trash virtual welcome zlib imap_acl imap_quota imap_sieve imap_zlib last_login } dovecot-shared-folder.conf: connect = host=/tmp/mysql.sock dbname=dbname user=username password=password # For shared mailboxes map { pattern = shared/shared-boxes/user/$to/$from table = user_shares value_field = dummy fields { from_user = $from to_user = $to } } # To share mailbox to anyone uncomment acl_anyone=allow in # 90-acl.conf map { pattern = shared/shared-boxes/anyone/$from table = anyone_shares value_field = dummy fields { from_user = $from } } dovecot-last-login.conf connect = host=/tmp/mysql.sock dbname=dbname user=user password=password # Last Login map { pattern = shared/last-login/$user table = virtual_users username_field = user value_field = lastlogin fields { username = $user } } global-acls #<identifier> <ACLs> [:<named ACLs>] # options: l lookup, r read, w write, s write-seen, # t write-deleted, i insert, p post, e expunge, # k create, x delete, a administration rights public/TestFolder user=username lrwstipekxa #owner lrwstipekxa # allow anyone to list and read a public mailbox public/* user=username lr # Prevent all users from deleting their Spam folder #INBOX.Spam owner lrwstipeka dovecot-trash.conf.ext # Spam mailbox is emptied before Trash 1 Spam # Trash mailbox is emptied before Sent 2 Trash # If both Sent and "Sent Messages" mailboxes exist, the next oldest message # to be deleted is looked up from both of the mailboxes. 3 Sent 3 Sent Messages # Junk mailbox is emptied 4 Junk dovecot-sql.conf.ext driver = mysql connect = host=/tmp/mysql.sock dbname=dbname user=user password=password default_pass_scheme = SHA512 password_query = SELECT user as user, password, \ CASE quota \ WHEN 0 \ THEN '*:bytes=256M:messages=0' \ ELSE \ CONCAT('*:bytes=', CAST(quota AS CHAR), 'M:messages=', CAST(quota_messages AS CHAR)) \ END AS `userdb_quota_rule` \ FROM virtual_users WHERE user='%u'; user_query = SELECT user as user, \ CASE quota \ WHEN 0 \ THEN '*:bytes=1024M:messages=0' \ ELSE \ CONCAT('*:bytes=', CAST(quota AS CHAR), 'M:messages=', CAST(quota_messages AS CHAR)) \ END AS `quota_rule` \ FROM virtual_users WHERE user='%u'; # For using doveadm -A: iterate_query = SELECT user AS user FROM virtual_users

1 0

Dovecot last_login plugin and Mysql
by David Mehler 29 Apr '17

29 Apr '17

Hello, Is anyone using the last_login plugin with a Mysql database? I'd like to track when users were last on the system. Thanks. Dave.

2 6

Re: dovecot mdbox never fix broken indexes
by CKoehl Listenaccount 28 Apr '17

28 Apr '17

Hey all, > Date: Tue, 31 Jan 2017 12:56:41 +0200 > From: Aki Tuomi <aki.tuomi(a)dovecot.fi> > To: dovecot(a)dovecot.org > Subject: Re: dovecot mdbox never fix broken indexes > Message-ID: <e6881175-8a48-ee24-6681-14427256d3a1(a)dovecot.fi> > Content-Type: text/plain; charset=utf-8 > > > > >> Also, if the file has indeed corrupted due to power loss, it's possible it's beyond repair, and you will have to delete the index file. This has the down side of losing flags, but it should repair this. > > Why dovecot not repair it by itself? > > > > It really should, as it's saying... Have to see why it's not successful > in this. > > Aki > is there anything new known about this? We are running dovecot 2.2.27 on solaris 10 and have several hundred accounts with this map inconsistency: Apr 27 12:51:06 <servername> dovecot: [ID 583609 local0.warning] lda(<userid>): Warning: mdbox /<storage-path>: Inconsistency in map index (10,29152 != 10,63560) The users of these accounts can't delete or move mails and often have trouble logging in or lags, because dovecot will try to fix the error and possibly disconnect them at any action. The warning does not occur on every action (imap/pop3 or lda). We did not have a hard reboot or any hardware trouble out of the ordinary (the machine is old and intermittently under higher load). After a variable length of time with these warnings the user accounts develop the following error: Apr 26 22:50:09 <servername> dovecot: [ID 583609 local0.error] imap(<userid>@): Error: Log synchronization error at seq=28,offset=117000 for /<storage-path>/dovecot.map.index: Extension record inc drops number below zero (uid=<uid>, diff=-1, orig=0) force-resync did not help at any stage of the problem and only got the index to continually count up. The only solution we found through which we could save the users flags is to copy the mdbox-files, delete the originals, and then re-import the copy into the user's account via doveadm import. Best regards, Catherina Koehl

1 0

Pigeonhole / Bug with "duplicate" ?
by Gilles Chauvin 28 Apr '17

28 Apr '17

Hello, Previously, while running Dovecot 2.2.27/Pigeonhole 0.4.16 the following code snippet was working as one would expect: if duplicate { addflag ["\\seen", "Duplicate"]; fileinto "Duplicate"; stop; } if address :contains "to" "user.email(a)example.com" { addflag "$label1"; } After upgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.18 it's not working anymore. When an e-mail is sent to the user the "$label1" isn't applied at all to the message (in the case it's NOT a duplicate). Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.17 exposes the same incorrect behaviour. Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.16 is OK. When running pigeonhole 0.4.17 & 0.4.18, commenting the "if duplicate {}" block restores the expected behaviour. Looks like a bug that appeared in 0.4.17? Am I correct? Kind regards, Gilles.

2 4

[BUG] OpenSSL function has been deprecated
by Peter van der Does 26 Apr '17

26 Apr '17

In src/lib-ssl-iostream/iostream-openssl-params.c a call is made to DH_generate_parameters. This function has been deprecated since OpenSSL 0.9.8. With OpenSSL 1.1 compilation will throw an error. Not sure how to send patches, I don't even know if the patch I wrote actually works (I don't program in C, but gave it a shot anyway) but below is the patch. --- a/src/lib-ssl-iostream/iostream-openssl-params.c +++ b/src/lib-ssl-iostream/iostream-openssl-params.c @@ -13,13 +13,21 @@ generate_dh_parameters(int bitsize, buffer_t *output, const char **error_r) { DH *dh; unsigned char *p; - int len, len2; + int len, len2, success; +#if OPENSSL_VERSION_NUMBER >= 0x00908000L + success = DH_generate_parameters_ex(dh, bitsize, DH_GENERATOR, NULL); +#else dh = DH_generate_parameters(bitsize, DH_GENERATOR, NULL, NULL); if (dh == NULL) { + success = 0; + } +#endif + + if (success == 0) { *error_r = t_strdup_printf( - "DH_generate_parameters(bits=%d, gen=%d) failed: %s", - bitsize, DH_GENERATOR, openssl_iostream_error()); + "DH_generate_parameters(bits=%d, gen=%d) failed: %s", + bitsize, DH_GENERATOR, openssl_iostream_error()); return -1; } -- If anybody knows the instruction on how to send patches, please let me know and I follow those instructions. Regards, Peter van der Does

2 3