- dovecot - dovecot.org

[Dovecot] Dual INBOX Locations
by Calum Power 18 Sep '05

18 Sep '05

G'day list, Just a quick question - I need to configure Dovecot to do the following: * check default_mail_env for the users' inbox in MBOX format * If the above fails, serve the user an inbox from a secondary location, in MAILDIR format. I have read up on Namespaces, however I can't seem to get this to work - login just fails when Dovecot cannot find the inbox in default_mail_env Any advice, anyone? :) Thanks, Calum -- Calum Power Systems Administrator Server101 Pty. Ltd. Fast, Reliable Web Hosting!

2 1

[Dovecot] Authentication Failure
by Dovecot 18 Sep '05

18 Sep '05

I installed Dovecot on our FC3 sendmail server and get this from our Dallas office ( out of state to me ). dovecot(pam_unix)[13823]: authentication failure; logname= uid=0 euid=0 tty= ruser= rhost Only one Dallas user can get mail (pop3 or imap). All local users work fine. I ended upgoing back to UW and all works fine. What should I look for? Thanks

2 1

[Dovecot] problems with Auth and Alpha 1a
by Søren Peter Skou 18 Sep '05

18 Sep '05

Hi all I'm not quite sure how to explain this problem, so I'll just go from the top ;-). System is setup on a FreeBSD with IMAP and POP3, both can use PAM and SQL (MySQL) as login methods, though only POP3 is accessible from "the world" - IMAP is restricted via firewall to only localhost. Simple eh? The problem is that dovecot apparently drops the SQL part from time to time. Though this can be fixed by HUPing the dovecotdaemon I'd rather that I didn't have to. I've narrowed the problem to something like this: Over time, Dovecot/POP3/SQL combination dies - I've yet to examine if the problem is on IMAP as well as this is only recently reported. I have never experienced this myself since I'm using Dovecot/IMAP/PAM and this seems to be rock solid. The configuration looks like this: OS: FreeBSD n/a 6.0-BETA3 FreeBSD 6.0-BETA3 #0: MySQL: 5.0.9-beta-log Dovecot: alpha 1 (I'll test Alpha 2 to see if the problem persists) Compilation options for dovecot: ./configure \ --enable-ipv6=no \ --with-ldap=no \ --with-vpopmail=no \ --with-mysql \ --with-ssl=no dovecot.conf: base_dir = /var/run/dovecot/ protocols = imap pop3 ssl_disable = yes disable_plaintext_auth = no login_user = dovecot login_process_per_connection = no login_greeting = Ready max_mail_processes = 1024 first_valid_uid = 1 first_valid_gid = 1 protocol imap { } protocol pop3 { } auth default { mechanisms = plain passdb pam { } userdb passwd { } passdb sql { args = /usr/local/etc/dovecot/mysql.conf } userdb sql { args = /usr/local/etc/dovecot/mysql.conf } user = root } -- END -- sql.conf: driver = mysql connect = host=localhost port=3306 dbname=N/A user=N/A password=N/A client_flags=0 default_pass_scheme = CRYPT password_query = SELECT password FROM mail WHERE username = '%n' and domain= '%d' user_query = SELECT concat('/VIRTUAL_MAIL/',domain,'/',username,'/') as home,concat('/VIRTUAL_MAIL/',domain,'/',username,'/') as mail, 1 as uid, 6 as gid FROM mail WHERE username = '%n' and domain = '%d' -- END -- I'm sort of at a loss here since everything "seems to be working" (tm) for one part, but not another Hope someone has an idea ;-) Søren P. Skou

2 1

[Dovecot] what does this mean: Warning: Error in custom flags file / Corrupted Indexes
by rick tait 18 Sep '05

18 Sep '05

Hi everyone: I am seeing a whole LOT of these messages in my dovecot logfile: imap(rickt): Sep 12 17:14:03 Warning: Error in custom flags file / home/rickt/mail/.imap/TRASH/.customflags: Duplicated ID 0 imap(rickt): Sep 12 17:14:03 Warning: Error in custom flags file / home/rickt/mail/.imap/TRASH/.customflags: Duplicated ID 1 and also these: imap(mbwnews): Sep 12 17:10:16 Error: Corrupted index file /home/ mbwnews/mail/.imap/INBOX/.imap.index: used_file_size larger than real file size (2016 vs 1608) imap(mbwnews): Sep 12 17:10:18 Error: Corrupted index file /home/ mbwnews/mail/.imap/INBOX/.imap.index: used_file_size larger than real file size (2016 vs 1608) And not just referring to my inbox, other users as well. I hava bog standard install of 0.99.10.8, on an openbsd 3.6 box. every now and then i get an error from my or my users' IMAP email client saying that it couldn't access a particular inbox. a few clicks of "OK" or "Cancel" etc and the problem seems to go away. all kinds of errors (similar to above) in the imapd logfile though, seem to correspond with the timing of the abovementioned IMAP mail client errors. one thing: my users DO use procmail, so there is a chance that their IMAP client might have a mailbox open that procmail may be trying to append to. i wonder if this is a locking issue? i guess what i'm asking is - 2 thing: 1) how can i get these pesky imap client errors to go away so my users mailboxes can be successfully selected? 2) what do the indexing errors mean? are the 2 things related? Thanks so very much in advance everyone! Best, Rick. rick tait | e: rickt(a)rickt.org | t: 323.829.5703

3 2

[Dovecot] Crashing error message
by Matt Juszczak 16 Sep '05

16 Sep '05

Sep 16 09:43:46 orion dovecot: imap(user): file mbox-sync-rewrite.c: line 375 (mbox_sync_read_and_move): assertion failed: (need_space == (uoff_t)-mails[idx].space) Got this message with all my signal 6 crashes.... Any ideas on interpretation? Thanks! -Matt

1 0

[Dovecot] Timeout while waiting for lock....
by Rob Frohne 16 Sep '05

16 Sep '05

Hi, I'm very new to administering mail, and this is surely a newbie question. I have my own IMAP mail server because I use my email as a way of filing important things, and I subscribe to a number of lists that I like to archive. I have about 40 mailboxes with up to 80,000 messages in some, and one with 40,000 messages is almost a Gigabyte in size. The total size is around 4 Gigabytes. Things were working quite well until I upgraded to OS X 10.4 and its new Mail.app mail client and then everything was too slow. I was using the UW IMAP server (2002d if I recall right) and Mail.app 1.3.9. I tried upgrading the server to the latest, but it didn't improve things noticeably. I swapped to dovecot 1.0alpha1, and used the mbox format, but that wasn't any better. I read that Maildir format was better, so I converted my mail to that format and tried that. It didn't seem much better. I tried to compile Cyrus on OS X and ran into all kinds of difficulty. I finally tried Cyrus on a Linux box, and turned off all my rules that move messages around. In comparing this to dovecot on my OS X box, Cyrus loads the messages significantly faster. I think there are some problems with my dovecot setup though. My mail.log is filled with this type of thing. Sep 15 16:43:51 cubex-wwc-edu dovecot: imap-login: Login: user=<frohro>, method=PLAIN, rip=172.17.128.191, lip=10.7.3.11 Sep 15 16:44:43 cubex-wwc-edu dovecot: imap(frohro): Timeout while waiting for lock for transaction log file /Users/frohro/Maildir/dovecot.index.log Sep 15 16:44:57 cubex-wwc-edu dovecot: imap-login: Login: user=<frohro>, method=PLAIN, rip=172.17.128.191, lip=10.7.3.11 Sep 15 16:45:51 cubex-wwc-edu dovecot: imap(frohro): Timeout while waiting for lock for transaction log file /Users/frohro/Maildir/dovecot.index.log I've tried mutt, evolution, kmail, and am now using Thunderbird, and am working on getting Mail.app to import an archive of my 4 Gigs of mail, thinking if nothing else works, I can have a copy of that on the clients I use, though I like having it on the server better. Can anyone suggest something to fix my problems, besides deleting all my email? Thanks, Rob

1 0

[Dovecot] SSL/TLS stopped working in 1.0 alpha2
by Andy Cravens 15 Sep '05

15 Sep '05

I have both 1.0 alpha1 and alpha2 installed on my test mail server. SSL/TLS does not work on alpha2. I'm using the same config file for both. No errrors in dovecot.log either. Is there a way to increase debugging info without recompiling?

2 3

[Dovecot] Dovecot Deliver Problem
by Marc Perkel 15 Sep '05

15 Sep '05

Trying to use the deliver utility and getting this error: error: net_connect(/var/run/dovecot/auth-master) failed: No such file or directory -- Marc Perkel - marc(a)perkel.com Spam Filter: http://www.junkemailfilter.com My Blog: http://marc.perkel.com

4 9

[Dovecot] Re: mailbox corruption
by Yannick Majoros 14 Sep '05

14 Sep '05

Kelly Sauke wrote: >Wietse Venema wrote: > > > >>Yannick Majoros: >> >> >> >> >>>>What else is accessing the mailbox files? Any scripts running around >>>>that access mail without proper file locking, like scripts that >>>>replicate mail to another box? >>>> >>>>Whay file system is being used? >>>> >>>>If you can't figure out which is broken, then you'll have to use >>>>maildir files. >>>> >>>> >>>> >>>> >>>> >>>No scripts. If amavisd-new is safe, then nothing else should access >>>mailboxes. Only via dovecot POP3/IMAP. Do you think it is worth to go >>> >>> >>> >>> >>amavisd-new accesses mailboxe files, and what file locking >>mechanism would that be using? >> >> Wietse >> >> >> >> >> >For what its worth, I'm seeing the exact same corruption as Yannick is >talking about and the only two pieces of software installed on my >machine are postfix and dovecot. One of those two is the culprit, not >sure which one. > > > Yep, I would think the same. This is not an evidence, but a strong doubt: the same problem is still present after replacing MailScanner by amavisd-new. It could be that it happens less often, although, but I need some time to make real stats... -- ---------------------------------------------------------------------- Yannick Majoros http://www.inma.ucl.ac.be/~majoros Informaticien AUTO-INMA/FSA/UCL CSAM 4, avenue G. Lemaître B-1348 Louvain-la-Neuve Belgium Tel: +32-10-47.80.10 Fax: +32-10-47.21.80 #JAPH : http://www.inma.ucl.ac.be/~majoros/japh.txt Si vous avez des problèmes pour afficher ce message (accents qui ne passent pas, signature électronique, ...) votre système de mail n'est pas conforme aux standards, voir http://www.inma.ucl.ac.be/~majoros/email.html ----------------------------------------------------------------------

3 2

[Dovecot] web-based mail
by str tux 14 Sep '05

14 Sep '05

Hello List, I just installed dovecot and i love the simplicity of the default config; it simply works. Now I want to setup and web-based in addition to the default pop3 and imap client access - what u guys can recommend? Thanks. str

8 11

[Dovecot] Dovecot-LDA problems (CVS version) Signal 11 and empty 'mail' dir
by Steffen Kaiser 14 Sep '05

14 Sep '05

Hello, I'm trying dovecot-lda (deliver.c has CVS version 1.18). When I try to deliver a mail, an empty directory is created name $HOME/mail. This is neither the configured (via LDAP) nor the default "mail" setting in the /usr/local/etc/dovecot-deliver.conf. When the $HOME directory does not exist, but the user itself: Sep 1 11:47:12 localhost deliver: mbox: Can't create root IMAP folder /home/skaise2a/mail: Permission denied Sep 1 11:47:13 localhost sm-mta[4684]: j819lCgd004682: SYSERR(root): mailer local died with signal 11 Default mail: mail = maildir:%h/.mailboxes:INDEX=/usr/local/var/spool/dovecot/indexes/%Lu Configured via LDAP for user skaise2a: maildir:/mailcache/skaise2a:INDEX=/var/cache/dovecot/indexes/skaise2a:CONTROL=/var/cache/dovecot/control/skaise2a I have only found the error message in dovecot's src/lib-storage/index/mbox/mbox-storage.c function create_root_dir(). The Dovecot logs indicate that dovecot-lda is requesting the information from it and the message is - once the empty directory could be created - delivered into the configured IMAP root. Bye, -- Steffen Kaiser

2 2

[Dovecot] mailbox corruption
by Yannick Majoros 14 Sep '05

14 Sep '05

Hello, Here is the description of a problem we habe been having for some time. Originally posted on the postfix-users mailing list, but no solution found to date. >>>> We have been having problems with our mail system for a couple of >>>> months. Every now and then, some mailboxes get corrupted: a >>>> half-truncated message, usually without headers, is at the beginning >>>> of the mailbox, causing it to become unaccessible. >>>> >>>> For information, we use: >>>> >>>> - fedora core 4 >>>> - postfix-2.2.2-2 rpm >>>> - dovecot-0.99.14-4.fc4 rpm >>>> - mailscanner-4.36.4-1 rpm >>>> >>>> >>> >>> This ^^^^^^^^^^ is probably your problem. >>> >>> >> > > I wouldn't be so quick to blame mailscanner. I have fc4, postfix rpm > and dovecot. Nothing else and I get the same corruption he is talking > about. > > > Ok, I removed MailScanner and I still have the very same problem. Locking _does_ work for postfix and dovecot (discussed with Wietse, partly by mail). Any idea? As an alternative, is there a way of handling the problem better? Dovecot just locks on these corrupt mailboxes :-/ I didn't try Dovecot 1.0, as it is alpha and I don't have any package for that anyway (production system :-/ ). Thank you, -- ---------------------------------------------------------------------- Yannick Majoros http://www.inma.ucl.ac.be/~majoros Informaticien AUTO-INMA/FSA/UCL CSAM 4, avenue G. Lemaître B-1348 Louvain-la-Neuve Belgium Tel: +32-10-47.80.10 Fax: +32-10-47.21.80 #JAPH : http://www.inma.ucl.ac.be/~majoros/japh.txt Si vous avez des problèmes pour afficher ce message (accents qui ne passent pas, signature électronique, ...) votre système de mail n'est pas conforme aux standards, voir http://www.inma.ucl.ac.be/~majoros/email.html ----------------------------------------------------------------------

3 3

[Dovecot] Solaris build failed
by GARY GENDEL 14 Sep '05

14 Sep '05

dovecot-v1.0-alpha build failed for Solaris 11 (OpenSolaris Nevada). The problematic line is in socket.c line 228. The fix should be to change SOL_TCP to IPPROTO_TCP found in netinet/in.h. This change should work universally on all platforms. Gary

2 1

[Dovecot] what does this mean: Warning: Error in custom flags file / Corrupted Indexes
by rick tait 13 Sep '05

13 Sep '05

Hi everyone: I am seeing a whole LOT of these messages in my dovecot logfile: imap(rickt): Sep 12 17:14:03 Warning: Error in custom flags file / home/rickt/mail/.imap/TRASH/.customflags: Duplicated ID 0 imap(rickt): Sep 12 17:14:03 Warning: Error in custom flags file / home/rickt/mail/.imap/TRASH/.customflags: Duplicated ID 1 and also these: imap(mbwnews): Sep 12 17:10:16 Error: Corrupted index file /home/ mbwnews/mail/.imap/INBOX/.imap.index: used_file_size larger than real file size (2016 vs 1608) imap(mbwnews): Sep 12 17:10:18 Error: Corrupted index file /home/ mbwnews/mail/.imap/INBOX/.imap.index: used_file_size larger than real file size (2016 vs 1608) And not just referring to my inbox, other users as well. I hava bog standard install of 0.99.10.8, on an openbsd 3.6 box. every now and then i get an error from my or my users' IMAP email client saying that it couldn't access a particular inbox. a few clicks of "OK" or "Cancel" etc and the problem seems to go away. all kinds of errors (similar to above) in the imapd logfile though, seem to correspond with the timing of the abovementioned IMAP mail client errors. one thing: my users DO use procmail, so there is a chance that their IMAP client might have a mailbox open that procmail may be trying to append to. i wonder if this is a locking issue? i guess what i'm asking is - 2 thing: 1) how can i get these pesky imap client errors to go away so my users mailboxes can be successfully selected? 2) what do the indexing errors mean? are the 2 things related? Thanks so very much in advance everyone! Best, Rick. rick tait | e: rickt(a)rickt.org | t: 323.829.5703

1 0

[Dovecot] Changing location of dovecot.conf file
by Andy Cravens 12 Sep '05

12 Sep '05

I've been looking through the configure options and can't seem to find a place to specify where dovecot.conf lives. I want the default location to be in /etc and not under the dovecot install directory tree. -- Andy

2 1

[Dovecot] An alternate "dovecot-auth" daemon using cyrus-sasl
by buc 12 Sep '05

12 Sep '05

We use dovecot in a heterogeneous environment (Windows/Linux desktops and Linux servers). For unified authentication we use a sheaf "Samba/Openldap" (i.e., Samba NT domain with openldap backend and pam/nss_ldap for Linux). Windows users are authenticated well everywhere, but there is one old issue. As "SPA" (NTLM) against NT domain is not supported by dovecot, it is necessary to use default "plain" method. In addition to security problems, it does also a problem of password unification. Each time a user changes the password, he should do it one more time for the mail program. I know that dovecot supports NTLM, however against local database only (not for NT domain controller). In early versions support of cyrus-sasl (which supports NTLM now) had been incorporated, however it like not work and now is removed. Fortunately, there is a possibility to substitute dovecot-auth executable. Therefore I have tried to make an alternate variant of dovecot-auth, which supports all that we need. For us, it seems to be more useful to create an auth daemon using cyrus-sasl, rather than to add domain support to existing ntlm code. First of all, it is easier for implementation. Besides it enables use of all mechanisms supported by cyrus-sasl (present and future), including GSSAPI. Anyway, it will be the useful additive to dovecot. I have made appropriate patches for both dovecot-1.0-stable and dovecot-1.0.alpha1. The idea is to copy "src/auth" to "src/auth-cyrus", strip all unneeded from newly created directory and add cyrus-sasl support. The resulting code probably looks not so elegantly as if it has been written separately, however this way allows to not make a lot of things from the scratch. The patch against 1.0.alpha1 is here: http://dmitry.butskoy.name/dovecot/dovecot-1.0.alpha1-cyrus.tar.gz . To be more readable, it is not a flat patch (due to a lot of whole files add/remove). It is a tarball with 3 files: a list of files to initial copy from auth/ to auth-cyrus/, a patch for resulting tree, and a script which automates this steps (:-)). (The script should be run in the root of the main source, i.e. a dir with src/ and doc/ subdirs). I already have successfully tested this patch with PLAIN method. However before testing of other methods, it would be desirable that somebody have looked at it. Whether someone could check up my patch (just fluently having read), at least for obvious bugs and typos? Dmitry Butskoy <Dmitry(a)Butskoy.name> Saint-Petersburg, Russia Red Hat Certified Engineer 809003662809495

4 3

[Dovecot] Dovecot feature request: move /var/mail/uid to INBOX
by Steffen Kaiser 12 Sep '05

12 Sep '05

Hello, UW-Imap has a (questional, but for me useful) feature to slurp all mails pending in /var/mail/uid into the user's INBOX whenever the user successfully logs on and the INBOX is not configured as /var/mail/uid. The usefulness for me is that users have a relatively small quota, so the noisy "over quota" messages pop up for everyone now and then, regardless how frequent one reads the mail. When I now set a large quota for the "pending INBOX", where the user (aka dovecot) can only delete mails from, I circumvent those messages, prevent that users use the (large) INBOX as yet another place to pile up data (the user does not know about the pending INBOX at all) and let the users have "full" control over their folders. The disadvantage is that it works for "real" users only. Another disadvantage is that one would expect "LDA"-features in the server portion of Dovecot, e.g. Sieve :-), or the server would need to spawn the Dovecot-LDA somehow. (Next thing is that, currently, the mails are delivered into the home directory of the users, what leads to several annoyances when someone is away for some time and finds his home directory locked, because the mass of mails locked the directory. Mostover, those IMAP servers I ran so far didn't allowed the user to delete a mail via IMAP often, because some temp or arbitary file couldn't created in the IMAP root. Because the user is already logged on onto Dovecot, there should be less problems deleting mails when the quota exceeds while slurping them in. At least I had extremly good experiences with this mechanism, when I used UW-Imap and the INBOX was located as mbx in the user's homedirectory.) Bye, -- Steffen Kaiser

1 0

[Dovecot] Authenfication on 2 databases
by LeeJaY 12 Sep '05

12 Sep '05

Hello, I have 2 databases MySQL. I would like to do that: If the user does not existe in the first base, it goes in the second database. my configuration auth default { mechanisms = plain passdb sql { args = /etc/dovecot-sql-1.conf } passdb sql { args = /etc/dovecot-sql-2.conf } userdb sql { args = /etc/dovecot-sql-1.conf } userdb sql { args = /etc/dovecot-sql-2.conf } } but it don't work, my version est 1.0.alpha1 if you not understand this message, i am sorry, my english is bad

6 16

[Dovecot] reading subfolders with mail.app
by Patrick Galbraith 12 Sep '05

12 Sep '05

Hi all, I have been having a hard time using Fedora Core 4 with dovecot +sendmail. Namely, I cannot read my home dir's procmail filtering dir (where I have some subfolders) in ~/mail. I cannot create mailboxes either. I'm wondering if this is a client issue, and whether I need to switch to Maildir, which I'd like to do, but don't know how to with sendmail (with postfix, it's a piece of cake). Any advice on what my problem is? I'm all ears! regards, Patrick

2 3

[Dovecot] 1.0alpha2 released
by Timo Sirainen 12 Sep '05

12 Sep '05

Changes: - Some cache file corruption fixes (shouldn't be any left?) - Some index file fixes with mmap_disable=yes - Some mbox syncing fixes - Timezones in mbox From-lines were handled wrong - Added pop3_reuse_xuidl setting. Patch by Chris Wakelin - "stack frame changed" crashfix for FETCH BODYSTRUCTURE - Added %R (reverse string) and %H (hash string) variable modifiers. These can be useful if you want to automatically split users to multiple partitions (eg. %3RHu gives values 0..2 based on the given username). See doc/variables.txt for more information. The POP3 bug mentioned in ChangeLog doesn't actually exist, so don't be alarmed by it :)

3 3

[Dovecot] variable expansion in dovecot.conf?
by OpenMacNews 11 Sep '05

11 Sep '05

hi all, does dovecot.conf support the definition/use of user variables? e.g., in principle, my_DIR = /path/to/something/ then, default_mail_env = maildir:${my_DIR}/%d/Accounts/%1u/%u/Maildir or, for that matter, default_mail_env = blahblah then, namespace private { ... location = $default_mail_env ... i finallly figured out -- through randon thrashing -- that the simple "$" format has been causing me grief ... and, cursory searching has not dug up anything (yet) in the man/wiki/etc. possible? reference docs for it? thx! (ack to my margarita for now ...) richard

2 2

[Dovecot] Do index files need removing when upgrading 1.0-stable to 1.0-alpha1 or later?
by Chris Wakelin 11 Sep '05

11 Sep '05

Hi Timo, Just a quick question: do index files still need removing when upgrading from 1.0-stable (as in the testXX series) or will Dovecot regenerate them automatically? I'm expecting to go with 1.0-stable on Tuesday for my 20,000 users (as that's what I've been testing), but if we see lots of index issues, I may want to upgrade to alpha1 (or later) fairly soon afterwards and it would be annoying to have do delete thousands of indexes! Best Wishes, Chris -- --+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+- Christopher Wakelin, c.d.wakelin(a)reading.ac.uk IT Services Centre, The University of Reading, Tel: +44 (0)118 378 8439 Whiteknights, Reading, RG6 2AF, UK Fax: +44 (0)118 975 3094

2 1

[Dovecot] 1.0alpha1: stack frame core
by Jeff A. Earickson 11 Sep '05

11 Sep '05

Hi, Today's core dump from 1.0alpha1 came from a syslog message of: IMAP(user): pool_data_stack_realloc(): stack frame changed gdb info on the resulting core dump attached. Question: how many people are building/using dovecot 1.0alpha1 with gcc 4.0.1 versus gcc 3.4.x? I am wondering if these issues come from the compiler instead of dovecot itself? Jeff Earickson Colby College

2 1

[Dovecot] 1.0alpha1: another imap core, no assert
by Jeff A. Earickson 11 Sep '05

11 Sep '05

Timo, Output of gdb session on the core file attached. This one only produced the following syslog: IMAP(user): UIDs broken with partial sync in mbox file /var/mail/r/user with no assert. Setup: Solaris 9, gcc 4.0.1 for dovecot build. Jeff Earickson Colby College

3 3

[Dovecot] 1.0alpha1: corrupted cache file complaints?
by Jeff A. Earickson 11 Sep '05

11 Sep '05

Hi, I have seen the following in my syslogs for 1.0alpha1: Corrupted index cache file [filename]: record points outside file and : indexid changed : record list is circular : Cache record offset 9772 points outside file : invalid record size Are these errors minor? Major? Self-healing? Should the cache files be blown away to fix these errors? Jeff Earickson Colby College

2 1